Skip to content

Commit

Permalink
Backport PR #15873: Fix missing signals in file editor adapter (#15886)
Browse files Browse the repository at this point in the history
Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
  • Loading branch information
meeseeksmachine and krassowski committed Feb 29, 2024
1 parent 7e9ff0e commit 2a489cf
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/fileeditor/src/fileeditorlspadapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ export class FileEditorAdapter extends WidgetLSPAdapter<
.then(async () => {
await this.initOnceReady();
this._readyDelegate.resolve();
this._editorAdded.emit({
editor: this._virtualEditor
});
})
.catch(console.error);
}
Expand Down Expand Up @@ -151,6 +154,9 @@ export class FileEditorAdapter extends WidgetLSPAdapter<
if (this.isDisposed) {
return;
}
this._editorRemoved.emit({
editor: this._virtualEditor
});
this.editor.model.mimeTypeChanged.disconnect(this.reloadConnection);
super.dispose();
}
Expand Down

0 comments on commit 2a489cf

Please sign in to comment.