Skip to content

Commit

Permalink
Remove whatwg-fetch polyfill (#16000)
Browse files Browse the repository at this point in the history
* Remove `whatwg-fetch` polyfill

* undo staging changes
  • Loading branch information
jtpio committed Mar 15, 2024
1 parent dda3210 commit 3946e3f
Show file tree
Hide file tree
Showing 19 changed files with 18 additions and 43 deletions.
1 change: 0 additions & 1 deletion dev_mode/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@
"webpack-bundle-analyzer": "^4.8.0",
"webpack-cli": "^5.0.1",
"webpack-merge": "^5.8.0",
"whatwg-fetch": "^3.0.0",
"worker-loader": "^3.0.2"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion dev_mode/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ module.exports = [
merge(baseConfig, {
mode: 'development',
entry: {
main: ['./publicpath', 'whatwg-fetch', entryPoint]
main: ['./publicpath', entryPoint]
},
output: {
path: path.resolve(buildDir),
Expand Down
3 changes: 1 addition & 2 deletions examples/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
"rimraf": "~5.0.5",
"style-loader": "~3.3.1",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
},
"jupyterlab": {
"extensions": [
Expand Down
2 changes: 1 addition & 1 deletion examples/app/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const extensionAssetConfig = Build.ensureAssets({

module.exports = [
{
entry: ['whatwg-fetch', './index.js'],
entry: ['./index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
3 changes: 1 addition & 2 deletions examples/cell/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"style-loader": "~3.3.1",
"typescript": "~5.1.6",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion examples/cell/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const webpack = require('webpack');
const miniSVGDataURI = require('mini-svg-data-uri');

module.exports = {
entry: ['whatwg-fetch', './build/index.js'],
entry: ['./build/index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
3 changes: 1 addition & 2 deletions examples/console/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"style-loader": "~3.3.1",
"typescript": "~5.1.6",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion examples/console/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const webpack = require('webpack');
const miniSVGDataURI = require('mini-svg-data-uri');

module.exports = {
entry: ['whatwg-fetch', './build/index.js'],
entry: ['./build/index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
3 changes: 1 addition & 2 deletions examples/federated/core_package/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@
"style-loader": "~3.3.1",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"webpack-merge": "^5.8.0",
"whatwg-fetch": "^3.0.0"
"webpack-merge": "^5.8.0"
},
"jupyterlab": {
"buildDir": "./build",
Expand Down
3 changes: 1 addition & 2 deletions examples/filebrowser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
"style-loader": "~3.3.1",
"typescript": "~5.1.6",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion examples/filebrowser/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const webpack = require('webpack');
const miniSVGDataURI = require('mini-svg-data-uri');

module.exports = {
entry: ['whatwg-fetch', './build/index.js'],
entry: ['./build/index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
3 changes: 1 addition & 2 deletions examples/notebook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
"style-loader": "~3.3.1",
"typescript": "~5.1.6",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion examples/notebook/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const webpack = require('webpack');
const miniSVGDataURI = require('mini-svg-data-uri');

module.exports = {
entry: ['whatwg-fetch', './build/index.js'],
entry: ['./build/index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
3 changes: 1 addition & 2 deletions examples/terminal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"style-loader": "~3.3.1",
"typescript": "~5.1.6",
"webpack": "^5.76.1",
"webpack-cli": "^5.0.1",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.1"
}
}
2 changes: 1 addition & 1 deletion examples/terminal/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const webpack = require('webpack');
const miniSVGDataURI = require('mini-svg-data-uri');

module.exports = {
entry: ['whatwg-fetch', './build/index.js'],
entry: ['./build/index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"rimraf": "~3.0.0",
"style-loader": "~3.3.1",
"webpack": "^5.72.0",
"webpack-cli": "^5.0.0",
"whatwg-fetch": "^3.0.0"
"webpack-cli": "^5.0.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const extras = Build.ensureAssets({

module.exports = [
{
entry: ['whatwg-fetch', './index.js'],
entry: ['./index.js'],
output: {
path: __dirname + '/build',
filename: 'bundle.js'
Expand Down
5 changes: 2 additions & 3 deletions packages/services/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@ Javascript client for the Jupyter services REST APIs

Note: All functions and classes using the REST API allow a `serverSettings`
parameter to configure requests.
Requests are made using the `fetch` API, which is available in modern browsers
or via `npm install fetch` for node users. The `whatwg-fetch` npm package
can be used to polyfill browsers that do not support the `fetch` API.

Requests are made using the `fetch` API, which is available in modern browsers or in Node 18+.

## Package Install

Expand Down
15 changes: 0 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2195,7 +2195,6 @@ __metadata:
webpack-bundle-analyzer: ^4.8.0
webpack-cli: ^5.0.1
webpack-merge: ^5.8.0
whatwg-fetch: ^3.0.0
worker-loader: ^3.0.2
languageName: unknown
linkType: soft
Expand Down Expand Up @@ -3029,7 +3028,6 @@ __metadata:
style-loader: ~3.3.1
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3059,7 +3057,6 @@ __metadata:
typescript: ~5.1.6
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand All @@ -3086,7 +3083,6 @@ __metadata:
typescript: ~5.1.6
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3148,7 +3144,6 @@ __metadata:
webpack: ^5.76.1
webpack-cli: ^5.0.1
webpack-merge: ^5.8.0
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3208,7 +3203,6 @@ __metadata:
typescript: ~5.1.6
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3244,7 +3238,6 @@ __metadata:
typescript: ~5.1.6
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -3320,7 +3313,6 @@ __metadata:
typescript: ~5.1.6
webpack: ^5.76.1
webpack-cli: ^5.0.1
whatwg-fetch: ^3.0.0
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -21608,13 +21600,6 @@ __metadata:
languageName: node
linkType: hard

"whatwg-fetch@npm:^3.0.0":
version: 3.6.2
resolution: "whatwg-fetch@npm:3.6.2"
checksum: ee976b7249e7791edb0d0a62cd806b29006ad7ec3a3d89145921ad8c00a3a67e4be8f3fb3ec6bc7b58498724fd568d11aeeeea1f7827e7e1e5eae6c8a275afed
languageName: node
linkType: hard

"whatwg-mimetype@npm:^2.3.0":
version: 2.3.0
resolution: "whatwg-mimetype@npm:2.3.0"
Expand Down

0 comments on commit 3946e3f

Please sign in to comment.