-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Fix settings heading hierarchy: do not use h3 for description as it distorts the outline which is detrimental to accessibility; instead use the `<header>` pattern as recommended by W3C in: https://www.w3.org/TR/2017/WD-html52-20170228/common-idioms-without-dedicated-elements.html Also, do not rely on style the caret icon by element but by class name (using this pattern reduces cognitive burden and improves performance). * Match font sizes to heading hierarchy * Remove unused rule (`field-description` is a class, not an ID, and this element is hidden anyways). * Make settings compact, display descriptions for all fields except for shortcuts which would take a lot of screen. Use flex-wrap for responsive display * Improve schema for settings editor * Implement add/remove/edit for objects, use JupyterLab button styles
- Loading branch information
1 parent
159b015
commit 6935ae0
Showing
5 changed files
with
243 additions
and
85 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.