unlink checkbox with setting

jupyterlab · May 13, 2024 · 7e0c6a6 · 7e0c6a6
1 parent f8e1aad
commit 7e0c6a6
Showing 1 changed file with 19 additions and 7 deletions.
diff --git a/packages/apputils/src/sessioncontext.tsx b/packages/apputils/src/sessioncontext.tsx
@@ -288,6 +288,11 @@ export namespace ISessionContext {
      * found (default `false`).
      */
     readonly autoStartDefault?: boolean;
+
+    /**
+     * Skip showing the kernel restart dialog if checked (default `false`).
+     */
+    readonly skipKernelRestartDialog?: boolean;
   }
 
   export type KernelDisplayStatus =
@@ -1421,13 +1426,15 @@ export class SessionContextDialogs implements ISessionContext.IDialogs {
 
     // Skip the dialog and restart the kernel
     const kernelPluginId = '@jupyterlab/apputils-extension:sessionDialogs';
+    const skipKernelRestartDialog =
+      sessionContext.kernelPreference?.skipKernelRestartDialog ?? false;
     const skipKernelRestartDialogSetting = (
       await this._settingRegistry?.get(
         kernelPluginId,
         'skipKernelRestartDialog'
       )
     )?.composite as boolean;
-    if (skipKernelRestartDialogSetting) {
+    if (skipKernelRestartDialogSetting || skipKernelRestartDialog) {
       await sessionContext.restartKernel();
       return true;
     }
@@ -1458,17 +1465,22 @@ export class SessionContextDialogs implements ISessionContext.IDialogs {
       return false;
     }
     if (result.button.accept) {
-      if (
-        typeof result.isChecked === 'boolean' &&
-        result.isChecked == true &&
-        this._settingRegistry
-      ) {
+      if (this._settingRegistry) {
         this._settingRegistry
           .set(kernelPluginId, 'skipKernelRestartDialog', !result.isChecked)
-          .catch(reason => {
+          .catch((reason: any) => {
             console.error(`Fail to set 'skipKernelRestartDialog:\n${reason}`);
           });
+      } else if (
+        typeof result.isChecked === 'boolean' &&
+        result.isChecked == true
+      ) {
+        sessionContext.kernelPreference = {
+          ...sessionContext.kernelPreference,
+          skipKernelRestartDialog: true
+        };
       }
+
       await sessionContext.restartKernel();
       return true;
     }