Skip to content

Commit

Permalink
Fix ServerApp.token deprecation warnings (#16011)
Browse files Browse the repository at this point in the history
  • Loading branch information
jtpio committed Mar 18, 2024
1 parent 9eea31b commit 98deb6f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion binder/jupyter_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"--debug",
"--port={port}",
"--ServerApp.ip=127.0.0.1",
'--ServerApp.token=""',
'--IdentityProvider.token=""',
# Disable dns rebinding protection here, since our 'Host' header
# is not going to be localhost when coming from hub.mybinder.org
"--ServerApp.allow_remote_access=True",
Expand Down
2 changes: 1 addition & 1 deletion jupyterlab/galata/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def configure_jupyter_server(c):
c.ServerApp.root_dir = os.environ.get(
"JUPYTERLAB_GALATA_ROOT_DIR", mkdtemp(prefix="galata-test-")
)
c.ServerApp.token = ""
c.IdentityProvider.token = ""
c.ServerApp.password = ""
c.ServerApp.disable_check_xsrf = True
c.LabApp.expose_app_in_browser = True
2 changes: 1 addition & 1 deletion jupyterlab/labapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -734,7 +734,7 @@ def initialize_handlers(self): # noqa
page_config.setdefault("buildAvailable", not self.core_mode and not self.dev_mode)
page_config.setdefault("buildCheck", not self.core_mode and not self.dev_mode)
page_config["devMode"] = self.dev_mode
page_config["token"] = self.serverapp.token
page_config["token"] = self.serverapp.identity_provider.token
page_config["exposeAppInBrowser"] = self.expose_app_in_browser
page_config["quitButton"] = self.serverapp.quit_button
page_config["allow_hidden_files"] = self.serverapp.contents_manager.allow_hidden
Expand Down

0 comments on commit 98deb6f

Please sign in to comment.