Check browser before starting CPD session

Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
jupyterlab · Dec 13, 2023 · cd42ea6 · cd42ea6
1 parent b0d7bce
commit cd42ea6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/galata/src/helpers/performance.ts b/galata/src/helpers/performance.ts
@@ -47,13 +47,18 @@ export class PerformanceHelper {
     downloadThroughput: number;
     uploadThroughput: number;
     latency: number;
-  }): Promise<CDPSession> {
-    const cdpSession = await this.page.context().newCDPSession(this.page);
-    await cdpSession.send('Network.emulateNetworkConditions', {
-      offline: false,
-      ...config
-    });
-    return cdpSession;
+  }): Promise<CDPSession | null> {
+    const browserName = this.page.context().browser().browserType().name();
+    if (browserName === 'chromium') {
+      const cdpSession = await this.page.context().newCDPSession(this.page);
+      await cdpSession.send('Network.emulateNetworkConditions', {
+        offline: false,
+        ...config
+      });
+      return cdpSession;
+    }
+    console.log('Browser does not support throttling network');
+    return null;
   }
 
   /**

diff --git a/galata/test/jupyterlab/completer.test.ts b/galata/test/jupyterlab/completer.test.ts
@@ -86,7 +86,7 @@ test.describe('Completer', () => {
       await page.waitForSelector('.jp-Completer-loading-bar', {
         state: 'detached'
       });
-      await session.detach();
+      await session?.detach();
       const imageName = 'completer-with-doc-panel.png';
       expect(await completer.screenshot()).toMatchSnapshot(imageName);
     });