Skip to content

Commit

Permalink
Remove SO links, add more recent issue to FAQ (#15811)
Browse files Browse the repository at this point in the history
* Remove SO links, add more recent issue to FAQ

* Replace one more SO link with the direct link to MS docs
  • Loading branch information
krassowski committed Feb 19, 2024
1 parent bb8a4ed commit d4c2f9f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
3 changes: 1 addition & 2 deletions docs/source/extension/ui_components.rst
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,7 @@ removed from the DOM, you’ll first need to clean it up:
This cleanup step is not a special property of ``LabIcon``, but is
instead needed for any React component that is rendered directly at the
top level by ``ReactDOM``: failure to call ``unmountComponentAtNode``
can result in a `memory
leak <https://stackoverflow.com/a/48198011/425458>`__.
can result in a memory leak.

How to create your own custom ``LabIcon``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down
8 changes: 5 additions & 3 deletions docs/source/getting_started/faq.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@ Development
- `How can you
contribute? <https://github.com/jupyterlab/jupyterlab/blob/main/CONTRIBUTING.md>`__
- :ref:`How can you extend or customize JupyterLab? <user_extensions>`
- In the classic Notebook, `I could use custom Javascript outputted by a cell to programmatically
control the Notebook <https://stackoverflow.com/a/32769976/907060>`__. Can I do the same thing in JupyterLab?
- In the classic Notebook, I could use custom Javascript outputted by a cell to programmatically
control the Notebook. Can I do the same thing in JupyterLab?

JupyterLab was built to support a wide variety of extensibility, including dynamic behavior based on notebook
outputs. To access this extensibility, you should write a custom JupyterLab extension. If you would
like trigger some behavior in response to the user executing some code in a notebook, you can output a custom
mimetype (:ref:`rendermime`). We currently don't allow access to the JupyterLab
API from the Javascript renderer, because this would tie the kernel and the notebook output to JupyterLab
and make it hard for other frontends to support it.
If you have comments or suggestions on changes here, please comment on `this issue <https://github.com/jupyterlab/jupyterlab/issues/4623>`__.
For more discussion and potential alternative solutions, please see issues
`#4623 <https://github.com/jupyterlab/jupyterlab/issues/4623>`__ and
`#5789 <https://github.com/jupyterlab/jupyterlab/issues/5789>`__.
6 changes: 3 additions & 3 deletions docs/source/user/extensions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,6 @@ rebuild, you can run the command:
If you are rebuilding JupyterLab on Windows, you may encounter a
``FileNotFoundError`` due to the default path length on Windows. Node
modules are stored in a deeply nested directory structure, so paths can get
quite long. If you have administrative access and are on Windows 8 or 10,
you can update the registry setting using these instructions:
https://stackoverflow.com/a/37528731.
quite long. If you have administrative access and are on Windows 10 or newer
you can enable long paths by adding a dedicated
`registry key <https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation>`__.

0 comments on commit d4c2f9f

Please sign in to comment.