Backport PR #15318: Fix scrolling when dragging files in the file bro…

…wser (#15370) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
jupyterlab · Nov 8, 2023 · e1b5d28 · e1b5d28
1 parent c0e8646
commit e1b5d28
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/packages/filebrowser/src/listing.ts b/packages/filebrowser/src/listing.ts
@@ -2251,6 +2251,8 @@ export namespace DirListing {
       const node = document.createElement('div');
       const header = document.createElement('div');
       const content = document.createElement('ul');
+      // Allow the node to scroll while dragging items.
+      content.setAttribute('data-lm-dragscroll', 'true');
       content.className = CONTENT_CLASS;
       header.className = HEADER_CLASS;
       node.appendChild(header);

diff --git a/packages/filebrowser/test/listing.spec.ts b/packages/filebrowser/test/listing.spec.ts
@@ -91,6 +91,16 @@ describe('filebrowser/listing', () => {
       });
     });
 
+    describe('#defaultRenderer', () => {
+      it('should enable scrolling when dragging items', () => {
+        const options = createOptionsForConstructor();
+        const dirListing = new DirListing(options);
+        expect(
+          dirListing.node.querySelector('[data-lm-dragscroll]')
+        ).toBeDefined();
+      });
+    });
+
     describe('#rename', () => {
       it('backspace during rename does not trigger goUp method', async () => {
         dirListing.selectNext();