Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider testing the debugger with ipykernel too #10385

Closed
jtpio opened this issue Jun 11, 2021 · 1 comment
Closed

Consider testing the debugger with ipykernel too #10385

jtpio opened this issue Jun 11, 2021 · 1 comment
Labels
pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing

Comments

@jtpio
Copy link
Member

jtpio commented Jun 11, 2021

The latest prereleases of ipykernel now include support for debugging: https://pypi.org/project/ipykernel/6.0.0rc0/

We should consider testing against it in the various tests in https://github.com/jupyterlab/jupyterlab/tree/master/packages/debugger/test.

For now it is assumed ipykernel does not support debugging here, but this is going to change soon:

describe('#isAvailable', () => {
it('should return true for kernels that have support for debugging', async () => {
const enabled = await service.isAvailable(xpython);
expect(enabled).toBe(true);
});
it('should return false for kernels that do not have support for debugging', async () => {
const enabled = await service.isAvailable(ipykernel);
expect(enabled).toBe(false);
});
});
});

This will also help ensure new features are not developed for one kernel only. Or they should at least not drastically degrade the experience for those that don't implement them yet.

As some point, there will also be more end to end testing of the debugger using Galata (#10359).

@fcollonval fcollonval linked a pull request Jun 22, 2021 that will close this issue
4 tasks
@fcollonval fcollonval removed a link to a pull request Jun 22, 2021
4 tasks
@jtpio
Copy link
Member Author

jtpio commented Nov 1, 2021

Closing as we now have mocks for the kernel specs in the debugger tests:

export const KERNELSPECS: JSONObject = {
default: 'xpython',
kernelspecs: {
python3: {
name: 'Python',
spec: {
language: 'python',
argv: [],
display_name: 'Python 3',
env: {}
},
resources: {}
},
xpython: {
name: 'xpython',
spec: {
language: 'python',
argv: [],
display_name: 'xpython',
env: {},
metadata: { debugger: true }
},
resources: {}
}
}
};

And UI Tests progressively covering more and more of the debugger features (which use ipykernel)

@jtpio jtpio closed this as completed Nov 1, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:debugger status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

No branches or pull requests

1 participant