Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more UI tests for the debugger #10406

Closed
wants to merge 3 commits into from

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 14, 2021

References

Follow-up to #10359

Code changes

There has been a couple of visual regression for the debugger in the past (breakpoints or variables not showing).

TODO

  • Open the debugger sidebar
  • Start and stop the debugger
  • Screenshot of the sidebar
  • Screenshot of the variable explorer (tree and grid views)

This change adds a couple more UI tests for the debugger, as well as reference screenshots for the debugger sidebar such as the following:

debugger_debugger_sidebar

Ideally, new visual tests will be added alongside new features in the future.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 3.1 milestone Jun 14, 2021
@jtpio
Copy link
Member Author

jtpio commented Jun 17, 2021

Some of the UI interactions could also be implemented in galata, under a new debugger namespace.

@jtpio
Copy link
Member Author

jtpio commented Jun 17, 2021

Also we can limit the scope of this PR to the basic debugger elements.

And expand on it incrementally in other PRs, with more complex interactivity like clicking on a breakpoint and opening the notebook or read only file.

@fcollonval fcollonval linked an issue Jun 22, 2021 that may be closed by this pull request
@blink1073 blink1073 modified the milestones: 3.1, 4.0 Jul 25, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 9, 2021

Closing as the structure of the UI tests has changed in the meantime with the Galata incorporation: #10796

Tracking in this issue instead: #11042

@jtpio jtpio closed this Sep 9, 2021
@jtpio jtpio deleted the debugger-ui-tests branch September 9, 2021 08:59
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants