Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completer places cursor in wrong position after dot complete (master) #10391

Closed
krassowski opened this issue Jun 11, 2021 · 2 comments
Closed

Completer places cursor in wrong position after dot complete (master) #10391

krassowski opened this issue Jun 11, 2021 · 2 comments
Assignees
@dmonad
Labels
bug pkg:completer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
3.1

Comments

@krassowski
Copy link
Member

Description

Probably follow up after #10234 is needed. Any thoughts @dmonad?

Reproduce

  1. Using Python kernel
  2. Enter dict. into a cell
  3. Press Tab
  4. Select any completion
  5. See the cursor still remaining after the dot rather than at the end of the chosen method

completer-cursor-issue

Expected behavior

The cursor caret lands after the chosen method i.e. dict.clear| (as it does in stable version) rather than dict.|clear

Context

  • Browser and version: Chrome
  • JupyterLab version: 3.1.0a12 / master
@krassowski krassowski added this to the 3.1 milestone Jun 11, 2021
@dmonad dmonad self-assigned this Jun 15, 2021
@dmonad
Copy link
Member

dmonad commented Jun 15, 2021

Thanks for the report, I'll work on this!

@krassowski
Copy link
Member Author

This is also happening on from ... import ...:

from-import

dmonad added a commit to dmonad/jupyterlab that referenced this issue Jul 19, 2021
@dmonad
fix jupyterlab#10391 (incorrect cursor position after autocomplete)
00755c3
@dmonad dmonad mentioned this issue Jul 19, 2021
Merged
dmonad added a commit to dmonad/jupyterlab that referenced this issue Jul 21, 2021
@dmonad
fix jupyterlab#10391 (incorrect cursor position after autocomplete)
07e232b
meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Jul 23, 2021
@dmonad @meeseeksmachine
Backport PR jupyterlab#10647: Fix jupyterlab#10391 - incorrect cursor…
aee15bf 
… position after autocomplete
@meeseeksmachine meeseeksmachine mentioned this issue Jul 23, 2021
Merged
blink1073 pushed a commit that referenced this issue Jul 23, 2021
@meeseeksmachine @dmonad
Backport PR #10647: Fix #10391 - incorrect cursor position after auto…
3cba08d 
…complete (#10689)

Co-authored-by: Kevin Jahns <kevin.jahns@protonmail.com>
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmonad dmonad

Labels
bug pkg:completer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@dmonad @krassowski