Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty raw cell & lost code cells in the virtual notebook #10435

Closed
krassowski opened this issue Jun 16, 2021 · 5 comments
Closed

Empty raw cell & lost code cells in the virtual notebook #10435

krassowski opened this issue Jun 16, 2021 · 5 comments
Assignees
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@krassowski
Copy link
Member

Description

An empty un-rendered raw cell appears in the virtual notebook on some undetermined actions. It can also eat the code cells as on the gif below.

Reproduce

This one is extremely difficult to reproduce. There is some chaos factor and it only appears one in a dozen attempts. Async isuse/race condition?

virtual-bug

Context

  • Browser and version: Chrome 91.0
  • JupyterLab version: 3.1.0a13
@krassowski krassowski added this to the 3.1 milestone Jun 16, 2021
@krassowski
Copy link
Member Author

krassowski commented Jun 16, 2021

I originally noticed it in an existing long notebook at the very end of it (so my reproduction attempts focused on it), but in that case it was not related to running cells at all - it was in there since the notebook was opened.

@echarles
Copy link
Member

echarles commented Jun 23, 2021

@krassowski I have tried a notebook with many empty cells (like your example) with current master, and indeed, I see a un-rendered cell at the end when I scroll. This happens in the case [1] I wait to scroll so the rendering is complete, and then scroll down to the bottom [2] If I scroll down while the virtual rendering is still happening. Is this the issue you were reporting or do you see also other issue (you are talking about "eat code cell")?

The remaining unrendered cell issue does not show-up with jupyterlab 2.3. Master aims to contain a port of the logic present in 2.3, so this maybe something to look at to nail-down the issue.

@krassowski
Copy link
Member Author

Is this the issue you were reporting or do you see also other issue (you are talking about "eat code cell")?

Yes this is the same issue, and yes there is (sometimes, not every time) an extra issue of executed cell disappearing; please see the GIF in first comment it was caught on record there; it does not happen every time I could not narrow conditions down.

The remaining unrendered cell issue does not show-up with jupyterlab 2.3. Master aims to contain a port of the logic present in 2.3, so many there is something to look there and this may help to nail-down the issue.

Yes, #10428 is another issue where it worked in 2.3 but does not work in 3.1.

@krassowski
Copy link
Member Author

The reproduction for the lost cell is in #10488.

@echarles
Copy link
Member

echarles commented Jul 2, 2021

Fixed with #10505

@echarles echarles closed this as completed Jul 2, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Dec 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants