Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrendered last cell and warning in the search function (3.1.0b1) #10578

Closed
krassowski opened this issue Jul 8, 2021 · 10 comments
Closed

Unrendered last cell and warning in the search function (3.1.0b1) #10578

krassowski opened this issue Jul 8, 2021 · 10 comments
Assignees
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@krassowski
Copy link
Member

Description

  1. I saw an unrendered cell appear at the end of the notebook when working in last or penultimate cell
  2. I noticed that the search bar shows a very verbose warning message saying the document is still loading (which indicates a loading error); this warning is stuck and does not go away after many minute since

Screenshot from 2021-07-08 12-37-00

There are no logs in developer console.

Reproduce

TBD

Expected behavior

  • User should never see un-rendered cell.
  • User should not see the "document is still loading warning" get stuck

Context

Previous similar issue reported in #10435 and deemed fixed with #10505 (which certainly improved things).

CC @echarles @goanpeca

  • Browser and version: Chrome 91
  • JupyterLab version: 3.1.0b1
@krassowski krassowski added the bug label Jul 8, 2021
@krassowski krassowski changed the title Unrendered last cell and incorrect warning in the search function (3.1.0b1) Unrendered last cell and warning in the search function (3.1.0b1) Jul 8, 2021
@krassowski krassowski added this to the 3.1 milestone Jul 8, 2021
@echarles
Copy link
Member

echarles commented Jul 8, 2021

I saw an unrendered cell appear at the end of the notebook when working in last or penultimate cell

Thx for reporting @krassowski. Can you detail a little bit the scenario driving to that issue? Are you seeing a un-rendered cell before working in the last cell?

@krassowski
Copy link
Member Author

I will fill in the details once I find a way to reproduce.

@krassowski
Copy link
Member Author

I encountered more suspicious behaviour related to cell rendering. Let's start by creating some cells:

adding-cells-causes-scroll

Now, I delete the empty cells I created and follow to add new cells with Shift + Enter again:

repro-3

this causes one of the cells to become unrendered. We can recover it by cut-paste operation:

can recover

I also encountered it in an earlier trial without the extra step of removing cells I think:

shift-enter-bheaviour

@echarles
Copy link
Member

echarles commented Jul 8, 2021

@krassowski I will look into the detailed report. You have at hand the scenario that fails, so if you could apply them on jupyterlab 2.3, this would help me to nail down the origin. Did we have some of those issue in 2.3 and didn't see them, or is it on master?

@krassowski
Copy link
Member Author

I also cannot focus one of the cells; I deleted other cells but this one remained and is inaccessible:

cannot-focus

More screencast:

more-recording

I will have a look at 2.3, but I did not use it earlier (other than testing on binder).

@krassowski
Copy link
Member Author

There might be an interaction with undo function as well.

@krassowski
Copy link
Member Author

Final comment: the issue above might be different from the original report because there is no issue with the search bar despite of cell being un-redered:

Screenshot from 2021-07-08 14-53-11

@echarles
Copy link
Member

echarles commented Jul 8, 2021

Did a few test on master (2.3 seems to behave the same) and I would say there is a special case of the last cell (there seems to be a explicit scrolling somewhere). Will look at fixes tomorrow.

@echarles
Copy link
Member

@krassowski I have opened a fix in #10602. The reported issue are solved, and I have not been able to reproduce a unrendered cell. However, please try out the fix, you may have more ideas to break it 👍

@blink1073
Copy link
Member

Fixed by #10602

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants