Fast forward button in notebook toolbar has tooltip " and "

[JasonWeill]

The fast-forward button in the notebook toolbar has the wrong tooltip.

Description

The ⏩ (fast forward) button in the notebook toolbar should have a tooltip that reads, in English, "Restart Kernel and Run All Cells …". This button was introduced in #8024.

Instead, this button has the tooltip " and " (with a space before and after the word) with no additional content. You can verify this by inspecting the element in your browser.

If you hover over a disabled fast-forward button, the tooltip is complete and present.

Reproduce

Open a notebook using JupyterLab (tip of master branch). Hover over the ⏩ button on the toolbar.

Expected behavior

A complete, comprehensible tooltip appears.

Context

• Operating System and version: macOS 11.6.2 (Big Sur)
• Browser and version: Firefox 91.4.1esr (64-bit), Chrome 97.0.4692.71 (Official Build) (x86_64)
• JupyterLab version: 4.0.0a19

[krassowski]

It sounds like related to "semantic commands" rewrite in #11386. It might have something to do with concatenateTexts (below)?

jupyterlab/packages/application/src/utils.ts

Lines 119 to 140 in 50fa004

	function concatenateTexts(
	attribute: 'label' | 'caption'
	): string | CommandRegistry.CommandFunc<string> | undefined {
	return () => {
	const texts = reduceAttribute(attribute);
	switch (texts.length) {
	case 0:
	return defaultValues.label ?? '';
	case 1:
	return texts[0];
	default: {
	const hasEllipsis = texts.some(l => /…$/.test(l));
	const main = texts
	.slice(undefined, -1)
	.map(l => l.replace(/…$/, ''))
	.join(', ');
	const end = texts.slice(-1)[0] + (hasEllipsis ? '…' : '');
	return trans.__('%1 and %2', main, end);
	}
	}
	};
	}

[JasonWeill]

Still shows up in tip-of-master