Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange default text when a empty markdown cell is previewed #12132

Open
yangql176 opened this issue Mar 1, 2022 · 1 comment
Open

Strange default text when a empty markdown cell is previewed #12132

yangql176 opened this issue Mar 1, 2022 · 1 comment

Comments

@yangql176
Copy link
Contributor

Problem

When preview a empty markdown cell would be like this:
image
It's very confusing.
image

Proposed Solution

It should be something more specific OR a empty string.

Additional context

@jtpio
Copy link
Member

jtpio commented Mar 11, 2022

Thanks @yangql176 for reporting.

Agree this could be confusing to users who haven't typed anything in the cell. Maybe the git history has some more information for why there is such default.

For reference the relevant code is located here:

const text = (model && model.value.text) || DEFAULT_MARKDOWN_TEXT;

A potential fix would be to remove the DEFAULT_MARKDOWN_TEXT constant, and default to '' instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants