Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show cell border when cell toolbar is hovered #12672

Open
JasonWeill opened this issue Jun 8, 2022 · 3 comments
Open

Only show cell border when cell toolbar is hovered #12672

JasonWeill opened this issue Jun 8, 2022 · 3 comments

Comments

@JasonWeill
Copy link
Contributor

JasonWeill commented Jun 8, 2022

Problem

Since the cell toolbar was added, hovering over a rendered Markdown cell displays a gray border. The first cell is auto-selected on page load and its border is visible.

Proposed Solution

Only display a gray border around the cell when the user hovers over or focuses a button in the cell toolbar. If a user hovers over or focuses other elements in the cell, do not display the gray border.

Additional context

Code added in #12028

@williamstein notes that Colab also has an outline on the focused markdown cell.

@JasonWeill JasonWeill added enhancement status:Needs Triage Applied to new issues that need triage pkg:cell-toolbar labels Jun 8, 2022
@JasonWeill
Copy link
Contributor Author

@aiqc notes that the first cell appears to be auto-selected on page load

@williamstein
Copy link

As noted, both cocalc and colab have an outline around focused markdown cells:

CoCalc

image

Colab

image

@krassowski
Copy link
Member

This seems like a good candidate for a quick survey among users to see whether they have a preference. I do not mind the extra border, some users might actually like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants