Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for editing notebook metadata #1308

Closed
blink1073 opened this issue Nov 28, 2016 · 18 comments
Closed

Add UI for editing notebook metadata #1308

blink1073 opened this issue Nov 28, 2016 · 18 comments

Comments

@blink1073
Copy link
Member

@blink1073 blink1073 commented Nov 28, 2016

No description provided.

@vidartf
Copy link
Member

@vidartf vidartf commented Nov 29, 2016

Related to #451 (?).

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Nov 29, 2016

Could be, the feature parity would be a simple text editor.

@ellisonbg
Copy link
Contributor

@ellisonbg ellisonbg commented Dec 23, 2016

I am fine with the feature parity version of this being a text editor, but we should implement it in the cell toolbar, which we are planning on making its own L side bar. See #902 for early design ideas.

@mpacer
Copy link
Member

@mpacer mpacer commented Jan 18, 2017

So for full feature parity notebook metadata and cell level metadata should probably be treated separately.

In the classic notebook:

  • notebook level metadata are editable from the "Edit → Notebook Metadata" menu dropdown.
  • cell level metadata are accessed by enabling cell level metadata editing with "View → Cell Toolbar → Edit Metadata" which enables the cell toolbar with an "Edit Metadata" button on the right hand side.

So, even if there is a metadata editor in the cell toolbar (for which I'm +1), it'd probably be good to have an additional/separate UI for editing the notebook's metadata that doesn't appear in the L side cell toolbar, even if it means just having a L side notebook toolbar if only to avoid confusion.

The other paradigm I could imagine would be that the notebook metadata is what is accessible when no cells are selected, but that seems a bit of a fraught solution.

@flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Jan 19, 2017

for feature partity with R notebooks, we also need to consider their advantages, e.g. in the field of metadata:

image

this is metadata for cell and notebook. note how the dialog for cell metadata has quite some features discoverable in the UI (the selectbox has the options “show output, show code, show both, show nothing and run code, show nothing and do nothing”). furthermore cell metadata is autocompleted.

@yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented Dec 23, 2018

I created my first JupyterLab extension to sort through this. You can try it out and check out the source code in https://github.com/yuvipanda/jupyterlab-nbmetadata

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Jan 25, 2019

Leaving as 1.0, since we really should have this functionality in core. Perhaps by including @yuvipanda's extension?

@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Feb 10, 2019

hey all, friendly ping on this :-) did this get in to the RC1?

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 10, 2019

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Feb 22, 2019

FYI, I've included a basic notebook metadata editor in #5968.

@blink1073 blink1073 removed their assignment Mar 13, 2019
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 23, 2019

Fixed in #5968.

@jasongrout jasongrout closed this Apr 23, 2019
@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 19, 2019

Is this feature documented anywhere? I see lots of notes that make me think it's now possible to edit notebook metadata in JupyterLab, but I cannot figure out how to do this...

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 19, 2019

@choldgraf I don't believe it is documented, but it is available under the "Advanced Tools" section in the cell tools:
Screen Shot 2019-06-19 at 2 06 31 PM

If you find a place to document this, that would be much appreciated!

@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 19, 2019

Hmmm, is that 'Advanced tools' thing activated somehow? I don't have that (running Lab 0.35.6)

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Jun 19, 2019

This was added after that release so only appears in the 1.0 releases (see the milestone on this is 1.0)

@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 19, 2019

ah ok and none of those are up on pip unless you're using --pre. gotcha :-)

@choldgraf
Copy link
Contributor

@choldgraf choldgraf commented Jun 19, 2019

y'all I am excited for jupyterlab 1.0 :-)

@lock
Copy link

@lock lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.