Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable news prompt #13969

Closed
domoritz opened this issue Feb 12, 2023 · 4 comments
Closed

Disable news prompt #13969

domoritz opened this issue Feb 12, 2023 · 4 comments
Labels
enhancement status:Answered The issue has been answered by a community member. status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up.
Milestone
Reference

Comments

@domoritz
Copy link
Member

The new prompt is breaking my visual regression tests. Is there an option to disable it in Galata automatically?

Screenshot 2023-02-12 at 12 59 02
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 12, 2023
@krassowski
Copy link
Member

Yes, just update galata to the latest version (4.5.0) and refresh lock files, and these will be disabled. Yesterday I went over this for ui-profiler (jupyterlab/ui-profiler#32). While at it I recommend to bump @jupyterlab/testutils to 3.6.0 to reduce number of false positive dependabot updates.

@domoritz
Copy link
Member Author

Sweet. I also found jupyter labextension disable "@jupyterlab/apputils-extension:announcements" disables it but it's even better that it's done automatically.

@krassowski krassowski added status:Answered The issue has been answered by a community member. and removed status:Needs Triage Applied to new issues that need triage labels Feb 12, 2023
@krassowski krassowski added this to the Reference milestone Feb 12, 2023
@domoritz
Copy link
Member Author

domoritz commented Feb 12, 2023 •
edited
Loading

Hmm, is there a change log somewhere? I am on 3.0.11-2 and updating the dev breaks (galata: command not found)?

@domoritz domoritz changed the title Disable new prompt Disable news prompt Feb 12, 2023
@fcollonval
Copy link
Member

fcollonval commented Feb 14, 2023 •
edited
Loading

@domoritz galata has been integrated to jupyterlab repository in August 2021 (see jupyterlab/galata#81).
You can look either at the project extension template : https://github.com/jupyterlab/extension-cookiecutter-ts/tree/3.0/%7B%7Bcookiecutter.python_name%7D%7D/ui-tests
Or update to @jupyterlab/galata@^4.5.0

For the documentation: https://github.com/jupyterlab/jupyterlab/tree/3.6.x/galata

@JasonWeill JasonWeill mentioned this issue Feb 22, 2023
Closed
@github-actions github-actions bot added the status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up. label Feb 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement status:Answered The issue has been answered by a community member. status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up.
Projects
None yet
Milestone
Reference
Development

No branches or pull requests
3 participants
@domoritz @krassowski @fcollonval