-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python icons in Launcher panel are different #13991
Comments
We were given a green light to use the one shown under "Other" (#13035 (comment)) so we could update the one in ipykernel for consistency (it was changed to use SVG vs PNG recently but no one notice that this is a different SVG). |
Yes the icon under "Other" is best, having drop shadows under icons is not necessary and quite old-fashioned. |
@dlqqq if you agree with the suggestion to keep the one from under "Other", shall we close this issue and open one on https://github.com/ipython/ipykernel? If not, shall we bump this issue to 4.2 milestone? |
@krassowski Thanks for checking on this. I agree with the sentiment that the flat icon under "Other" looks the best. Can you open the issue on |
Description
The buttons for launching a notebook with the Python kernel and for creating a new Python file both use a Python icon, but they look different. It is best to stick to one or the other to preserve consistency in the UI. This is of special significance given that this is what most users see first when launching JL.
Reproduce
Expected behavior
The icons should be the same.
Context
I believe I had discussed this earlier when working on my CSS PR (now sadly abandoned). If I recall, the Python icons used at the top are actually coming from the kernel and are not hard-coded in the JL frontend. Would appreciate additional context from anybody knowledgable on this.
The text was updated successfully, but these errors were encountered: