Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python icons in Launcher panel are different #13991

Closed
dlqqq opened this issue Feb 13, 2023 · 5 comments
Closed

Python icons in Launcher panel are different #13991

dlqqq opened this issue Feb 13, 2023 · 5 comments

Comments

@dlqqq
Copy link
Contributor

dlqqq commented Feb 13, 2023

Description

The buttons for launching a notebook with the Python kernel and for creating a new Python file both use a Python icon, but they look different. It is best to stick to one or the other to preserve consistency in the UI. This is of special significance given that this is what most users see first when launching JL.

Screen Shot 2023-02-13 at 2 27 59 PM

Reproduce

  1. Open JupyterLab
  2. Observe the Python icons are different

Expected behavior

The icons should be the same.

Context

  • Operating System and version: OS X Monterey
  • Browser and version: Chrome 109.0.5414.119 (Official Build) (x86_64)
  • JupyterLab version: 4.0.0a33 binder

I believe I had discussed this earlier when working on my CSS PR (now sadly abandoned). If I recall, the Python icons used at the top are actually coming from the kernel and are not hard-coded in the JL frontend. Would appreciate additional context from anybody knowledgable on this.

@dlqqq dlqqq added the bug label Feb 13, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 13, 2023
@JasonWeill JasonWeill added this to the 4.1.0 milestone Feb 15, 2023
@JasonWeill JasonWeill added tag:Design and UX and removed status:Needs Triage Applied to new issues that need triage labels Feb 15, 2023
@krassowski
Copy link
Member

We were given a green light to use the one shown under "Other" (#13035 (comment)) so we could update the one in ipykernel for consistency (it was changed to use SVG vs PNG recently but no one notice that this is a different SVG).

@GabrielaVives
Copy link

Yes the icon under "Other" is best, having drop shadows under icons is not necessary and quite old-fashioned.

@krassowski
Copy link
Member

@dlqqq if you agree with the suggestion to keep the one from under "Other", shall we close this issue and open one on https://github.com/ipython/ipykernel? If not, shall we bump this issue to 4.2 milestone?

@dlqqq
Copy link
Contributor Author

dlqqq commented Dec 20, 2023

@krassowski Thanks for checking on this. I agree with the sentiment that the flat icon under "Other" looks the best.

Can you open the issue on ipython/ipykernel, and link to it here via a comment? I'll close this issue after you reply with the link of the new issue here.

@krassowski
Copy link
Member

ipython/ipykernel#1183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants