Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown paragraphs are not centered vertically when rendered #14251

Open
JasonWeill opened this issue Mar 21, 2023 · 1 comment
Open

Markdown paragraphs are not centered vertically when rendered #14251

JasonWeill opened this issue Mar 21, 2023 · 1 comment
Labels
bug tag:Bug Bash Issue opened during an event to find bugs in a new release

Comments

@JasonWeill
Copy link
Contributor

Description

Markdown paragraphs are not centered vertically when rendered. To fix we would need to be careful about spacing.

Screen Shot 2023-03-20 at 3 10 09 PM

(found by @ellisonbg)

Context

  • Operating System and version: macOS
  • Browser and version: Firefox
  • JupyterLab version: 4.0.0a37
@JasonWeill JasonWeill added bug status:Needs Triage Applied to new issues that need triage tag:Bug Bash Issue opened during an event to find bugs in a new release and removed status:Needs Triage Applied to new issues that need triage labels Mar 21, 2023
@fcollonval
Copy link
Member

Indeed this requires to be careful. For instance what is happening when there are two paragraphs.

To fix this, I would suggest looking at the reason for the input cell to be larger than the text (I guess this is conditioned by the toolbar height). Adding a top margin or padding sounds not like a good approach as it will reduce the vertical space available for content going against the lengthy discussion we already had when introducing the cell toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tag:Bug Bash Issue opened during an event to find bugs in a new release
Projects
None yet
Development

No branches or pull requests

2 participants