Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusting notebook in RTC mode leads to File Changed dialog #14347

Open
krassowski opened this issue Apr 8, 2023 · 0 comments
Open

Trusting notebook in RTC mode leads to File Changed dialog #14347

krassowski opened this issue Apr 8, 2023 · 0 comments
Labels
bug help wanted tag:Real Time Collaboration

Comments

@krassowski
Copy link
Member

Description

Regardless of fixes in #14345 the trust status is not set for empty (1 code cell) notebooks on RTC, and an attempt to Trust notebook ends up with File Changed dialog.

Reproduce

trust-rtc-itneraction

  1. Spin up RTC setup on binder
  2. Open command palette
  3. Choose "Trust Notebook"
  4. Click Trust
  5. See File Changed dialog

Expected behavior

  • whatever causes the trusted metadata to be lost on code cells when RTC is active gets ironed out.
  • trusting notebook works the same on RTC as it works locally, without dialog.

Context

  • Browser and version: latest Chromium family
  • JupyterLab version: 4.0.0b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted tag:Real Time Collaboration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krassowski @JasonWeill