Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when releasing 4.0.0b2 #14431

Closed
jtpio opened this issue Apr 25, 2023 · 6 comments
Closed

Issues when releasing 4.0.0b2 #14431

jtpio opened this issue Apr 25, 2023 · 6 comments
Assignees
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Apr 25, 2023

Tracking issues that happened during the 4.0.0b2 release.

HTTP Error 401: Unauthorized

Trying to use the workflows from the repo directly kept giving 401 errors: HTTP Error 401: Unauthorized:

Commented here: #14176 (comment)

This could be related to the bot ADMIN_GITHUB_TOKEN.

Packages not available on npm yet

This looks like an issue on npm which might be fixed automatically after a while. It is still 4.0.0-beta.1 for now although the publish step seems to have gone though: https://www.npmjs.com/package/@jupyterlab/application?activeTab=versions

image

image

For reference the release workflow was done from the releaser fork because of the issue mentioned above: https://github.com/jtpio/jupyter_releaser/actions/runs/4794491472/jobs/8527930831

Not sure there is much we can do for now. Will open a ticket on npm if the issue persists.


Once the npm issue is fixed I will undraft the release manually:

image

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Apr 25, 2023
@jtpio jtpio added this to the 4.0.0 milestone Apr 25, 2023
@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

I just sent a message to the npm support.

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

For reference everything seems fine at the moment according to https://status.npmjs.org:

image

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

Ah the status is now showing "Degraded performance of npm publish": https://status.npmjs.org/incidents/nhmby0vny5xy

image

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

Looks like it's been resolved:

image

image

The GitHub Release has now been undrafted: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0b2

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

Trying to use the workflows from the repo directly kept giving 401 errors: HTTP Error 401: Unauthorized:

Leaving the issue open for now to double check the bot token is correct, so it's not an issue for future releases.

@jtpio
Copy link
Member Author

jtpio commented Apr 25, 2023

Closing the issue, as the discussion about the token is now happening in jupyterlab/frontends-team-compass#190.

@jtpio jtpio closed this as completed Apr 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants