Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the extra config in CodeEditor.IEditor #1456

Closed
blink1073 opened this issue Jan 6, 2017 · 0 comments · Fixed by #1460
Closed

Remove the extra config in CodeEditor.IEditor #1456

blink1073 opened this issue Jan 6, 2017 · 0 comments · Fixed by #1460
Assignees
@blink1073
Labels
pkg:codeeditor status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
0.31.0

Comments

@blink1073
Copy link
Contributor

This inherently leaks the implementation. We are not currently using it for CodeMirror, nor is it used in the Monaco implementation (#1382).
@blink1073 blink1073 added this to the Beta milestone Jan 6, 2017
@blink1073 blink1073 mentioned this issue Jan 9, 2017
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blink1073 blink1073

Labels
pkg:codeeditor status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
0.31.0
Development

Successfully merging a pull request may close this issue.

Remove the extra parameter from CodeEditor.IOptions blink1073/jupyterlab
2 participants
@ellisonbg @blink1073