Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completer documentation rendering by completion providers #15127

Open
krassowski opened this issue Sep 16, 2023 · 0 comments
Open

Completer documentation rendering by completion providers #15127

krassowski opened this issue Sep 16, 2023 · 0 comments

Comments

@krassowski
Copy link
Member

Description

Currently the renderer of the first completion provider (with highest rank) is always used. This means that if different formats of documentation are provided by different providers, the results are sub-optimal as the renderers of top provider may not know how to render other formats.

Expected behavior

Either:

  • createDocumentationNode should be called on per-item instance, using the renderer of corresponding provider
  • we have a good-enough default that will satisfy downstreams, i.e. allowing to render a MIME bundle (e.g. markdown with LaTeX typsetter); in this scenario dowsntreams would only override createDocumentationNode if they wanted to add some extra/dynamic details which need to live outside of the mime bundle.

Context

  • JupyterLab version: 4.0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants