Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo/redo does not work in JSON settings editor #15232

Open
krassowski opened this issue Oct 6, 2023 · 1 comment
Open

Undo/redo does not work in JSON settings editor #15232

krassowski opened this issue Oct 6, 2023 · 1 comment
Labels
bug pkg:settingeditor tag:Regression Behavior that had been broken, was fixed, and is broken again
Milestone
4.0.x

Comments

@krassowski
Copy link
Member

Description

After changing things in the JSON settings editor undo with ctrl + z is not possible

Expected behavior

Undo works in code mirror editors which are not y.js enabled.

Context

  • Browser: Chrome
  • JupyterLab version: 4.0.6 and earlier
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage tag:Regression Behavior that had been broken, was fixed, and is broken again labels Oct 6, 2023
@krassowski krassowski added this to the 4.0.x milestone Oct 6, 2023
@bollwyvl
Copy link
Contributor

bollwyvl commented Oct 9, 2023

Also effects the cell/notebook metadata editor, i believe....

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Oct 10, 2023
@JasonWeill JasonWeill mentioned this issue Oct 10, 2023
Closed
@krassowski krassowski mentioned this issue Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pkg:settingeditor tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Milestone
4.0.x
Development

No branches or pull requests
3 participants
@bollwyvl @krassowski @JasonWeill