Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror settings – suppress "Default: [object Object]" below section when settings are changed #15323

Closed
firai opened this issue Oct 29, 2023 · 0 comments · Fixed by #15380

Comments

@firai
Copy link
Contributor

firai commented Oct 29, 2023

Problem

When any of the settings within a CodeMirror settings section in the Settings Editor (i.e., in the CodeMirror, Notebook, Text Editor and Code Console pages), the user's settings object no longer matches the default settings object, and "Default: [object Object]" appears below the CodeMirror settings section. However, the message does not seem to be meaningful or helpful for the user, so it just adds visual noise to the settings pages, which are already quite dense.

image

Proposed Solution

Don't display the default when the setting schema type is object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants