Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visited link are invisible in light theme #15403

Closed
fcollonval opened this issue Nov 14, 2023 · 3 comments · Fixed by #15406
Closed

Visited link are invisible in light theme #15403

fcollonval opened this issue Nov 14, 2023 · 3 comments · Fixed by #15406
Labels
bug tag:CSS For general CSS related issues and pecadilloes tag:Release Blocker A must-have bug for the milestone to which it is tagged
Milestone
4.1.0

Comments

@fcollonval
Copy link
Member

Description

The color --jp-content-link-visited-color used for the light theme makes it invisible

image

Reproduce

  1. Go to the extension manager
  2. Click on a link to open a extension home page
  3. Come back to jupyterlab

Expected behavior

The text is visible also in light theme

Context

Main branch
Tested on Firefox and Chrome

That color was introduced by #15181

For reference this is how it looks with the dark theme:

image
@fcollonval fcollonval added bug status:Needs Triage Applied to new issues that need triage tag:Release Blocker A must-have bug for the milestone to which it is tagged labels Nov 14, 2023
@fcollonval
Copy link
Member Author

@m158261 by any chance do you have time to solve this issue?

@fcollonval fcollonval added the tag:CSS For general CSS related issues and pecadilloes label Nov 14, 2023
@m158261
Copy link
Contributor

m158261 commented Nov 14, 2023

Hey @fcollonval. Yeah, I'll try and get that fixed today.

@m158261 m158261 mentioned this issue Nov 14, 2023
Merged
@m158261
Copy link
Contributor

m158261 commented Nov 14, 2023

Hi @fcollonval. I've raised a PR. #15406

@JasonWeill JasonWeill added this to the 4.1.0 milestone Nov 14, 2023
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Nov 14, 2023
@JasonWeill JasonWeill mentioned this issue Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tag:CSS For general CSS related issues and pecadilloes tag:Release Blocker A must-have bug for the milestone to which it is tagged
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Updated light theme visited link colour to make text visible m158261/jupyterlab
3 participants
@fcollonval @JasonWeill @m158261