Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File dialog loads slowly when using defaultPath #15453

Closed
mmichilot opened this issue Nov 28, 2023 · 1 comment · Fixed by #15463
Closed

File dialog loads slowly when using defaultPath #15453

mmichilot opened this issue Nov 28, 2023 · 1 comment · Fixed by #15463

Comments

@mmichilot
Copy link
Contributor

Description

When using FileDialog.getOpenFiles with the defaultPath option, it takes a while (~10 seconds) to load the file list. However, when it's manually refreshed, the file list loads immediately.
OpenDialogBug

When defaultPath is not given, the file list is loaded immediately, however this limits the file dialog to starting from the root folder.

Reproduce

Create a file dialog with FileDialog.getOpenFiles and pass a defaultPath option.

Expected behavior

I would've expected the file list the to load once the dialog opened, especially since manually refreshing works immediately.

Context

  • Browser and version: Firefox 119
  • JupyterLab version: 4.1.0a3
@mmichilot mmichilot added the bug label Nov 28, 2023
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Nov 28, 2023
@krassowski
Copy link
Member

It sounds like it could be that it does not take 10s but you see it auto-refresh every 10s. So maybe the initial reply is not handled correctly to populate the contents or maybe there is just a missing update after the initial response was received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants