Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the jlpm update for JupyterLab 4.1? #15503

Closed
jtpio opened this issue Dec 8, 2023 · 4 comments · Fixed by #15526
Closed

Revert the jlpm update for JupyterLab 4.1? #15503

jtpio opened this issue Dec 8, 2023 · 4 comments · Fixed by #15526
Labels
status:Needs Discussion tag:Release Blocker A must-have bug for the milestone to which it is tagged
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Dec 8, 2023

#15295 updated the yarn used by jlpm to version 3.6.4.

#15295 also includes some discussions on how this affects extension repos and other repos using the jlpm command.

For example the release of JupyterLab 4.1.0a4 required updating the yarn.lock in the Notebook repo, as the Notebook CI started to fail shortly after the release: jupyter/notebook#7170

This is expected to be the same for most extension repos using jlpm.

The question is: should we revert this change in JuyterLab 4.1 to avoid disrupting third-party extensions workflows too much?

Technically the fix is not too difficult and was documented in jupyter/notebook#7170. But it's still an annoyance to extension authors and if we can avoid it it may be better.

cc @krassowski @fcollonval @bollwyvl since you commented in jupyter/notebook#7170.

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Dec 8, 2023
@jtpio jtpio added this to the 4.1.0 milestone Dec 8, 2023
@jtpio jtpio changed the title Undo jlpm update for JupyterLab 4.1? Revert the jlpm update for JupyterLab 4.1? Dec 8, 2023
@bollwyvl
Copy link
Contributor

bollwyvl commented Dec 9, 2023

Maybe there is a way to put something in @jupyterlab/builder that would transparently heal these kinds of things?

@jtpio
Copy link
Member Author

jtpio commented Dec 12, 2023

Maybe there is a way to put something in @jupyterlab/builder that would transparently heal these kinds of things?

Doing some automatic repairs would be nice, but not sure to see how this would prevent CI builds from failing? (as illustrated in the previous discussion)

Also @jupyterlab/builder might not necessarily be "in sync" with the jupyterlab Python package (which provides jlpm). For example an extension can depend on @jupyterlab/builder@^4.0.9 with 4.0.9 in its lock, while the latest jupyterlab stable release will at some point be 4.1.

@krassowski
Copy link
Member

krassowski commented Dec 12, 2023

Maybe we could remove pnp plugin from jlpm using yarnpkg/berry#2384 (comment) which would remove the patch and hash issue altogether? Since all we can do is manipulate jlpm in 4.1, we could make it inject a preinstall script which removes the hash... but this assumes that downstream did not want to use it which is not something we would know.

@JasonWeill JasonWeill added tag:Release Blocker A must-have bug for the milestone to which it is tagged and removed status:Needs Triage Applied to new issues that need triage labels Dec 12, 2023
@ericsnekbytes
Copy link
Contributor

During triage we decided to revert this change.

Triage Notes:

  • We can print messages in the install script to inform extension devs
  • Option: Revert the last yarn update...or ship both versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:Needs Discussion tag:Release Blocker A must-have bug for the milestone to which it is tagged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants