New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual tests, allow to disable termianal cursor blinking #15524
Conversation
by mock `tree . -L 2` command
To fix flaky terminal tests
This was already use in `build:src`
Thanks for making a pull request to jupyterlab! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
Thanks @krassowski
I have a minor suggestion. Otherwise it is good for me.
Thank you @krassowski!! |
Co-authored-by: Frédéric Collonval <fcollonval@users.noreply.github.com>
cd42ea6
to
199e7c2
Compare
In one run these two failed, on re-run they passed. I think these will be addressed by #15375.
Good to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@meeseeksdev please backport to 4.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
* Try to make the test terminal snapshot more robust by mock `tree . -L 2` command * Workaround `test-` dirs issue by capturing `/data` instead of `/` * Update Playwright Snapshots * Run customization docs snapshots in serial * Ignore all test files in galata tests * Update Playwright Snapshots * Disable concurrency in `build:examples` to fix flaky test This was already use in `build:src` * Ensure no flaky focus indicator on snapshot (cherry picked from commit c26a0e7)
* Backport PR #15524: Fix visual tests * Try to make the test terminal snapshot more robust by mock `tree . -L 2` command * Workaround `test-` dirs issue by capturing `/data` instead of `/` * Update Playwright Snapshots * Run customization docs snapshots in serial * Ignore all test files in galata tests * Update Playwright Snapshots * Disable concurrency in `build:examples` to fix flaky test This was already use in `build:src` * Ensure no flaky focus indicator on snapshot (cherry picked from commit c26a0e7) * Update Playwright Snapshots * Revert some snapshot updates * Update Playwright Snapshots * Try to fix "General › Welcome" documentation snapshot --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
References
Linux Tests / Linux (examples, 3.11) (pull_request)
test (concurrency again?) #15510Code changes
performance.throttleNetwork
galata helper and use it to solve flakiness of completer test when trying to catch the loading indicator,tree
command output for terminal snapshottest-
directories form concurrent tests showing up in the snapshotsUser-facing changes
We always supported
cursorBlink
in API but it was not exposed. This PR adds it to user-facing schema. We need it for tests, and for accessibility, but we should remove it from backport and only release in 4.1.Backwards-incompatible changes
None