Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook is permissioned as read-only shows up incorrectly on RTC #15547

Closed
krassowski opened this issue Dec 20, 2023 · 2 comments · Fixed by #15597
Closed

Notebook is permissioned as read-only shows up incorrectly on RTC #15547

krassowski opened this issue Dec 20, 2023 · 2 comments · Fixed by #15597
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Milestone
4.1.0

Comments

@krassowski
Copy link
Member

Description

#15317 introduced a helpful pop-up which shows on ctrl + s in read-only notebooks. Because RTC advertises its model as read-only, it leads to a spurious notification on every ctrl + S

Reproduce

  1. Open a notebook with RTC mode on, you can use https://mybinder.org/v2/gist/krassowski/847732eb6c16e168fb4c0b16d9706142/HEAD?urlpath=lab
  2. Change something
  3. Press Ctrl + S
  4. See the spurious notification:
    image

Expected behavior

No notification in this case

Context

CC @andrewfulton9
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage tag:Release Blocker A must-have bug for the milestone to which it is tagged labels Dec 20, 2023
@krassowski krassowski added this to the 4.1.0 milestone Dec 20, 2023
@JasonWeill JasonWeill added the tag:Regression Behavior that had been broken, was fixed, and is broken again label Jan 2, 2024
@JasonWeill
Copy link
Contributor

@andrewfulton9 Can you please take a look at this when using real-time collaboration (RTC)?

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Jan 2, 2024
@andrewfulton9
Copy link
Contributor

Yeah, I'll take a look asap

@JasonWeill JasonWeill mentioned this issue Jan 2, 2024
Open
@andrewfulton9 andrewfulton9 mentioned this issue Jan 2, 2024
Merged
@krassowski krassowski linked a pull request Jan 3, 2024 that will close this issue
Fix ctrl+s notification incorrectly showing up in RTC mode #15597
Merged
@JasonWeill JasonWeill mentioned this issue Jan 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Fix ctrl+s notification incorrectly showing up in RTC mode andrewfulton9/jupyterlab
3 participants
@krassowski @andrewfulton9 @JasonWeill