Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark tests triggered on comment #15569

Closed
brichet opened this issue Dec 27, 2023 · 1 comment · Fixed by #15630
Closed

Benchmark tests triggered on comment #15569

brichet opened this issue Dec 27, 2023 · 1 comment · Fixed by #15630
Labels
bug maintenance

Comments

@brichet
Copy link
Contributor

brichet commented Dec 27, 2023 •
edited

Description

The benchmark tests are triggered every time a comment is added in a PR.

This may be related to #15523.

Example:

https://github.com/jupyterlab/jupyterlab/actions/runs/7337248858

Reproduce

Write a comment in a PR.

Expected behavior

Do not trigger the tests for each comment.
@brichet brichet added bug status:Needs Triage Applied to new issues that need triage labels Dec 27, 2023
@JasonWeill
Copy link
Contributor

I have also been seeing this today during triage: every comment I add triggers a workflow, which causes me to get email with the results of the flow.

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Jan 2, 2024
@JasonWeill JasonWeill mentioned this issue Jan 2, 2024
Open
@krassowski krassowski mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix syntax error in benchmark workflow krassowski/jupyterlab
3 participants
@krassowski @brichet @JasonWeill