Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running/rendering cell with ctrl + enter inserts a new line at the end #15605

Closed
krassowski opened this issue Jan 4, 2024 · 1 comment · Fixed by #15638
Closed

Running/rendering cell with ctrl + enter inserts a new line at the end #15605

krassowski opened this issue Jan 4, 2024 · 1 comment · Fixed by #15638
Assignees
@krassowski
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Milestone
4.1.0

Comments

@krassowski
Copy link
Member

Description

Rendering or running a cell with ctrl + enter inserts an empty line at the end.

Reproduce

  1. Run an empty code or markdown cell with ctrl + enter
  2. See new line inserted

repro

Expected behavior

No new line is inserted.

Context

This does not happen in 4.0.10.
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged labels Jan 4, 2024
@krassowski krassowski added this to the 4.1.0 milestone Jan 4, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Jan 9, 2024
@JasonWeill JasonWeill mentioned this issue Jan 9, 2024
Open
@krassowski krassowski self-assigned this Jan 10, 2024
@krassowski
Copy link
Member Author

krassowski commented Jan 13, 2024 •
edited

This is working in 4.1.0a3 but broken in 4.1.0a4. It looks likely related to #14115

The enter insertion happens before execution of lumino shortcut handler, so we need to catch it at codemirror level.

@krassowski krassowski mentioned this issue Jan 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krassowski krassowski

Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again tag:Release Blocker A must-have bug for the milestone to which it is tagged
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

Fix new line getting inserted when running cells with Ctrl + Enter krassowski/jupyterlab
2 participants
@krassowski @JasonWeill