Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the "Click to add a cell" button be excluded from tab navigation? #15611

Closed
krassowski opened this issue Jan 6, 2024 · 0 comments · Fixed by #15679
Closed

Should the "Click to add a cell" button be excluded from tab navigation? #15611

krassowski opened this issue Jan 6, 2024 · 0 comments · Fixed by #15679
Assignees
Milestone

Comments

@krassowski
Copy link
Member

Description

JupyterLab 4.1 includes improved tab-navigation (#14115). However, I find one aspect particularly annoying: whenever I press Tab in command mode (sometimes accidental, because I did not realise I was not in the edit mode) the notebook scrolls to the very end because the focus jumps to "Click to add a cell" which causes distraction and annoyance.

  • when I am in the middle of the notebook I almost never want to add a cell at the end of the notebook
  • it feels like the "Click to add a cell" button should only be navigable with up/down as all cells are because in essence it is a cell placeholder

Reproduce

Either:

  1. Enter command mode in a cell somewhere in the beginning or a middle of a notebook
  2. Press Tab
  3. See you are in a cell toolbar (ok)
  4. Press Tab again
  5. See the notebook scrolled away to the bottom
  6. If you worked on two notebooks side-by-side be annoyed that you cannot switch to the other notebook with keyboard only without loosing the cell you were working out of view; even in a single notebook be annoyed that you lost the context and if you pressed Tab one more time no number of Shift + Tab will land you back at the cell you were working on

with-cell-toolbar

Even worse:

  1. Disable cell toolbar with jupyter labextension disable @jupyterlab/cell-toolbar-extension
  2. Repeat the instructions above but it happens on first Tab making it even worse

without-cell-toolbar

Expected behavior

The "add cell" button is excluded from tab navigation and instead navigable with up/down arrow keys and j/k keys (as it is).

Context

  • JupyterLab version: 4.1.0b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants