-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action updating visual test reference snapshots fails #15631
Comments
There was one commit to the main branch of https://github.com/jupyterlab/maintainer-tools in this range of dates, jupyterlab/maintainer-tools@fe20cc9 @blink1073 do you see any way it could have been related? |
Nothing in that diff looks relevant, and oddly enough |
Comparing the successful and failing jobs, there is a difference in - + '[' linux-gnu == Linux ']'
+ + '[' linux-gnu == linux-gnu ']'
+ ++ which yarn
+ + sudo rm -rf /usr/local/bin/yarn
+ + yarn
+ ./scripts/ci_install.sh: line 19: yarn: command not found
+ mkdir -p /home/runner/.jupyter
+ git config --global user.name foo
+ git config --global user.email foo@bar.com
+ pip install -q --upgrade pip --user
+ pip --version and later: - + yarn --version
- 3.5.0
+ node -p process.versions So it looks like this must have been introduced by #11801, CC @jtpio |
I guess we can try switching to using
|
Maybe this could also help when jlpm is updated to a newer of yarn, so we use the same version everywhere. |
Unfortunately, I don't think this issue is fixed yet: |
Right sorry - it works for main snapshots but not for docs; PR on the way. |
As seen in a few recent PRs the action updating snapshots fails:
It seems to have last worked on
main
https://github.com/jupyterlab/jupyterlab/actions/runs/7338404549/job/19980875086and was no longer working by 6th Jan 2024 (#15612 (comment))
The text was updated successfully, but these errors were encountered: