New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSTYPE
check in ci_install.sh
#11801
Conversation
Thanks for making a pull request to jupyterlab! |
The failing |
b980622
to
764b558
Compare
5c70df9
to
1f365f5
Compare
1f365f5
to
c824b09
Compare
50a7242
to
2a19396
Compare
2a19396
to
0cf98b6
Compare
So both Taking a second look at it, it seems we are using cc @blink1073 just to confirm such change would be appropriate. |
Yes that sounds correct. |
4b70a7d
to
6c6370c
Compare
cc @jupyterlab/release for awareness This should be good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, though I do not have the full context here.
Thanks @krassowski and @blink1073 for the review!
This is mostly to fix this condition on CI noticed in #11770 (comment). |
Merging as CI is now all passing. |
References
As noticed in #11770 (comment), the check against
$OSTYPE
in theci_install.sh
script doesn't seem to be hit at the moment.Code changes
Update CI install script to see if this has any affect on the CI checks.
User-facing changes
None
Backwards-incompatible changes
None