Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlpm run integrity needs to be run twice #15664

Open
krassowski opened this issue Jan 19, 2024 · 0 comments
Open

jlpm run integrity needs to be run twice #15664

krassowski opened this issue Jan 19, 2024 · 0 comments

Comments

@krassowski
Copy link
Member

Running jlpm run integrity when a new dependency was added adds it at the end of tsconfig.json lists. This leads the tests to fail. Further, the output is not aligned with prettier which changes it again. A contributor needs to run:

jlpm run integrity
prettier # (e.g. from pre-commit)
jlpm run integrity
pretttier

This can lead to a total of six commands and is especially erogenous when run in environments where CI is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants