You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default file browser's title, aria label, and role are set outside of the plugin that provides the default file browser (@jupyterlab/filebrowser-extension:default-file-browser), and are instead defined in the extension that adds the default file browser to the lab shell, here:
Arguably, these attributes are inherently part of the "content" of the file browser and the responsibility for setting them and keeping them updated should be with the @jupyterlab/filebrowser-extension:default-file-browser plugin instead so that an alternative file browser (e.g., suppose it is called "Git Browser" or "Cloud Browser", has a different icon, etc.) can correctly display its icon, caption, aria label, etc. without it being clobbered when it is added to JupyterLab.
** Proposal **
Move this functionality from @jupyterlab/filebrowser-extension:widget to @jupyterlab/filebrowser-extension:default-file-browser.
The default file browser's title, aria label, and role are set outside of the plugin that
provides
the default file browser (@jupyterlab/filebrowser-extension:default-file-browser
), and are instead defined in the extension that adds the default file browser to the lab shell, here:jupyterlab/packages/filebrowser-extension/src/index.ts
Lines 437 to 458 in ae54125
Arguably, these attributes are inherently part of the "content" of the file browser and the responsibility for setting them and keeping them updated should be with the
@jupyterlab/filebrowser-extension:default-file-browser
plugin instead so that an alternative file browser (e.g., suppose it is called "Git Browser" or "Cloud Browser", has a different icon, etc.) can correctly display its icon, caption, aria label, etc. without it being clobbered when it is added to JupyterLab.** Proposal **
Move this functionality from
@jupyterlab/filebrowser-extension:widget
to@jupyterlab/filebrowser-extension:default-file-browser
.cc: @DenisaCG
The text was updated successfully, but these errors were encountered: