Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Regression Documentation tests action uses Node.js 16, which is deprecated #15698

Closed
JasonWeill opened this issue Jan 25, 2024 · 4 comments · Fixed by jupyterlab/maintainer-tools#235
Milestone

Comments

@JasonWeill
Copy link
Contributor

Description

In the run details for visual regression tests, I see an error:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3, ifaxity/wait-on-action@v1, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Expected behavior

We need to upgrade these actions to Node 20, which is still supported until late 2024, with maintenance continuing until Q2 2026. NodeJS ended support on September 11, 2023.

@JasonWeill JasonWeill added bug maintenance status:Needs Triage Applied to new issues that need triage labels Jan 25, 2024
@krassowski
Copy link
Member

krassowski commented Jan 25, 2024

Rhe above is referring to 4.0.x branch; on main there is only one of these (ifaxity/wait-on-action@v1):

The following actions uses node12 which is deprecated and will be forced to run on node16: ifaxity/wait-on-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Of note there might be even older versions on 3.6.x branch.

@krassowski krassowski added this to the 4.0.x milestone Jan 25, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Jan 30, 2024
@krassowski
Copy link
Member

Depends on iFaxity/wait-on-action#12

@krassowski
Copy link
Member

A few remain:

actions/setup-python@v4, actions/cache@v3, actions/setup-node@v3

but these are not defined in https://github.com/jupyterlab/jupyterlab/blob/main/.github/workflows/galata.yml but from dependencies too.

@krassowski
Copy link
Member

Will be fixed by jupyterlab/maintainer-tools#235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants