Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing "Enter" in the console inserts two new lines #15771

Closed
divyansshhh opened this issue Feb 8, 2024 · 4 comments
Closed

Pressing "Enter" in the console inserts two new lines #15771

divyansshhh opened this issue Feb 8, 2024 · 4 comments
Labels
bug pkg:console status:Answered The issue has been answered by a community member. status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up.

Comments

@divyansshhh
Copy link
Contributor

Description

Pressing "Enter" while in the console inserts two new lines in the input box. Here's a gif -
extra-new-line

Reproduce

Open the console, type something, press enter.

Context

  • JupyterLab v4.1.0rc1
@divyansshhh divyansshhh added the bug label Feb 8, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 8, 2024
@krassowski
Copy link
Member

I cannot reproduce this on Binder:

4.0.12 4.1.0 (plain) 4.1.0 (with extensions)
works-in-4 0 12 works-in-4 1-without-extensions works-in-4 1-with-extensions

But I was able to reproduce this locally. However, after clearing custom shortcuts the issue disappeared.

Is there any warning in the console related to shortcuts? Can you paste any modified shortcuts that show up in user panel in JSON Settings Editor which related to console commands or include Enter?

@lstngr
Copy link

lstngr commented Feb 14, 2024

I had the same issue and I can confirm that resetting keyboard shortcuts resolved the issue for me (they were all showing up as “Custom” for some reason). Thank you @krassowski !

@divyansshhh
Copy link
Contributor Author

they were all showing up as “Custom” for some reason

I see this as well. Not sure why this happened.

I had the same issue and I can confirm that resetting keyboard shortcuts resolved the issue for me

It resolved the issue for me too, surprisingly, copying all the shortcuts to custom doesn't reproduce this issue for me.

@krassowski
Copy link
Member

One possibility is that this was fixed in 4.1.0beta1 by #15639 and only occurred for users who tried 4.1.0beta0 or earlier (or even some version of 4.0.x) but even after upgrading manual cleaning of user shortcuts was required.

@krassowski krassowski added the status:Answered The issue has been answered by a community member. label Feb 15, 2024
@github-actions github-actions bot added the status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up. label Feb 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug pkg:console status:Answered The issue has been answered by a community member. status:Closing as Answered The issue will be closed soon as answered unless there is further follow-up.
Projects
None yet
Development

No branches or pull requests

4 participants