Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't drag and drop cells out of viewport #15777

Closed
divyansshhh opened this issue Feb 9, 2024 · 2 comments · Fixed by #15782
Closed

Can't drag and drop cells out of viewport #15777

divyansshhh opened this issue Feb 9, 2024 · 2 comments · Fixed by #15782
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again
Milestone

Comments

@divyansshhh
Copy link
Contributor

Description

In lab3, it was possible to drag and drop a cell out of the initial viewport because the viewport would scroll. This doesn't happen in lab4. Here's a gif showing the differences in behavior -
Drap-n-drop

Reproduce

shown in gif

Expected behavior

I expect the behavior in lab4 to be the same as lab3

Context

  • JupyterLab v4.1.0rc1
@divyansshhh divyansshhh added the bug label Feb 9, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 9, 2024
@krassowski krassowski added this to the 4.1.x milestone Feb 9, 2024
@krassowski
Copy link
Member

I can reproduce in 4.1.0 but not in 4.0.12, tagging as regression.

@krassowski krassowski added the tag:Regression Behavior that had been broken, was fixed, and is broken again label Feb 9, 2024
@krassowski
Copy link
Member

This is another regression introduced by virtual scrollbar PR (#15533) which changed the DOM structure (confirmed as working in 4.1.0a4 but failing in 4.1.0b0). We need to move data-lm-dragscroll="true" to jp-WindowedPanel-outer and add a test because it's the second time it broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants