Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Enter no longer puts user into insert mode #15793

Open
mlucool opened this issue Feb 12, 2024 · 4 comments
Open

Shift+Enter no longer puts user into insert mode #15793

mlucool opened this issue Feb 12, 2024 · 4 comments
Labels

Comments

@mlucool
Copy link
Contributor

mlucool commented Feb 12, 2024

Description

Shift+Enter no longer puts the user into insert mode in the cell below unless its a new cell

Reproduce

JLInsertBug

Expected behavior

Same as 3.x

Context

Lab@4.1.0

@mlucool mlucool added the bug label Feb 12, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Feb 12, 2024
@krassowski krassowski modified the milestone: 4.1.x Feb 12, 2024
@krassowski
Copy link
Member

This is very interesting because I was halfway writing up a bug report on this earlier this week and then realised that is also the case on 3.6.x:

3.6.3 3.6.7
3 6 3 3 6 7

Now also checked 3.5.3 and 3.5.0 - all work the same:

3 5 x

I also checked a local installation with 3.6.5 to rule out interference from extensions on Binder.

Either this changed in an even earlier version, or the new outline ring denoting focus in command mode does something to the brain which makes it feel counter-intuitive that the mode has changed on Shift + Enter.

@krassowski
Copy link
Member

I find the fact that the behaviour is different in the last cell odd. I think it might be desirable to make this user-configurable.

@mlucool
Copy link
Contributor Author

mlucool commented Feb 12, 2024

Humm...maybe this has always been like this? Maybe what feels distracting/different is the highlighting around the cell? It's ok to close this given it didn't change

@krassowski
Copy link
Member

Maybe what feels distracting/different is the highlighting around the cell?

I concur. I think we should explore different focus indicators, for example making the blue collapser bar to the left of a cell empty if the active cell is not focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants