You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I thought it would be possible to recreate a yarn.lock, by removing it and invoking jlpm, but I get this error at jlpm run build:
> @jupyterlab/buildutils@4.1.2 build
> tsc && cd template && npm run build
../node_modules/@yarnpkg/fslib/lib/ZipFS.d.ts:208:5 - error TS2416: Property 'readdirPromise' in type 'ZipFS' is not assignable to the same property in base type 'BasePortableFakeFS'.
Type '{ (p: import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").PortablePath): Promise<import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").Filename[]>; (p: import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").PortablePath, opts: { ...; } | null): Promise<......' is not assignable to type '{ (p: import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").PortablePath): Promise<import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").Filename[]>; (p: import("/home/david/tmp/jupyterlab/node_modules/@yarnpkg/fslib/lib/path").PortablePath, opts: { ...; } | null): Promise<......'. Two different types with this name exist, but they are unrelated.
Type 'Promise<Filename[]>' is not assignable to type 'Promise<Dirent[]>'.
Type 'Filename[]' is not assignable to type 'Dirent[]'.
Type 'Filename' is not assignable to type 'Dirent'.
Type 'String & { __pathType: PathType.File; }' is missing the following properties from type 'Dirent': isFile, isDirectory, isBlockDevice, isCharacterDevice, and 5 more.
208 readdirPromise(p: PortablePath): Promise<Array<Filename>>;
~~~~~~~~~~~~~~
I think this can be closed since #15996 bumped the yarn version used in buildutils to fix this issue, see comments #15996 (comment) and #15996 (comment).
Description
I thought it would be possible to recreate a
yarn.lock
, by removing it and invokingjlpm
, but I get this error atjlpm run build
:Reproduce
git clone https://github.com/jupyterlab/jupyterlab.git
cd jupyterlab
pixi init
pixi add pip nodejs
pixi shell
pip install hatch
pip install -e .
rm yarn.lock
jlpm
jlpm run build
This issue suggests that this issue has been fixed in later version of
yarn
, but it seems that JupyterLab vendorsyarn
v3.5.0.Expected behavior
We should be able to recreate a
yarn.lock
.Context
The text was updated successfully, but these errors were encountered: