Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings editor does not load tabs of some plugins on first open #15871

Open
krassowski opened this issue Feb 25, 2024 · 0 comments
Open

Settings editor does not load tabs of some plugins on first open #15871

krassowski opened this issue Feb 25, 2024 · 0 comments

Comments

@krassowski
Copy link
Member

Description

When "Settings" Editor is opened before the loading/transformation of settings completed, the tabs for packages which were not ready are not shown. Closing and re-opening the "Settings" Editor after the settings for remaining packages got loaded helps.

This especially affects Code Completion and Inline Completer settings (both using jupyter.lab.transform), but it was also reported for extensions which do not use jupyter.lab.transform but are just loaded later, e.g.:

Another report for this issue was in: jupyter-lsp/jupyterlab-lsp#1053

Reproduce

  1. Open "Settings Editor"
  2. Take a note of the list of "SETTINGS"
  3. Refresh page (so that JupyterLab loads with "Settings Editor" already open)
  4. Compare the list of "SETTINGS" now with the one from step (2)
  5. See that a number of tabs is now missing
On first open After reopening
Screenshot from 2024-02-25 17-04-28 Screenshot from 2024-02-25 17-04-08

Expected behavior

Settings for all plugins are are shown regardless of when they get loaded/activated/transformed.

There are two options:

  • (a) the "Settings" widget shows with whatever is ready and additional tabs show up as new plugins finish loading or as transformation of settings gets completed
  • (b) the "Settings" widget only opens once all plugins are ready

I think we should go for (a) because (b) might lead to the "Settings" widget not showing up in a reasonable time at all.

Context

  • JupyterLab version: 4.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants