Shift-tab unindent vs. docstring/signature information

[schmidi314]

Description

Shift-tab has (at least) two functions: (1) unindenting one level and (2) showing signature and docstring of a function. If typed inside of an indented function

Reproduce

1. New notebook
2. Define some function

def test(a,b):
    print(a, b)

3. Use test(a,b) indented

if True:
    test(a, b)

4. With cursor inside test(a,b) parentheses, hit shift-tab. --> info is shown AND test is unindented

Expected behavior

Only info should be shown. NO un-indentation.

Context

• Operating System and version: Linux and Windows tried
• Browser and version: Firefox
• JupyterLab version: 4.1.2

[krassowski]

@schmidi314 thanks for opening the issue, I believe this is a duplicate of #15821 (regression in 4.1); there is a pull request fixing it (#15898) - help in review of the PR would be appreciated!

[schmidi314]

Ah yes, @krassowski you're right. My apologies. I didn't understand the word "dedent" :)

I tried your PR via binder and it solves my problem. Thanks for tackling this! Is there anything I can do? (you mentioned help in review..??) Unfortunately I'm pretty busy these days so I couldn't really get active in this repo like I planned.

[krassowski]

Thanks @schmidi314! If you could leave a review comment on #15898 just saying that you tried this via binder and it does the intended thing it would already be of a help to other reviewers as they no longer need to validate that it does the thing but only to look at the code to check if it looks right. Of course if you feel like looking at the code as well and leaving any comments that would be appreciated too but I was suggesting just testing it out and leaving a comment over in the PR :)

[krassowski]

I didn't understand the word "dedent" :)

It is confusing with so many code verbs used for roughly the same things ("dedent", "unindent", "outdent", "indent less")

[JasonWeill]

Closing in favor of #15821.