Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete shortcuts through the settings UI #15937

Closed
divyansshhh opened this issue Mar 7, 2024 · 1 comment · Fixed by #16043
Closed

Delete shortcuts through the settings UI #15937

divyansshhh opened this issue Mar 7, 2024 · 1 comment · Fixed by #16043

Comments

@divyansshhh
Copy link
Contributor

Problem

It would be helpful for users if they can use the settings editor to delete shortcuts too. Currently it only allows modifying but the original shortcut remains.

Additional context

Jupyterlab v4.1.2

@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Mar 7, 2024
@krassowski
Copy link
Member

It is possible to disable default shortcuts using "disabled" attribute but it is not exposed in the settings UI.

We could either:

  • (a) add "[ ] disabled" checkbox for shortcuts which would allow disabling the default shortcuts (but it would require more changes to allow adding another row for a custom shortcut)
  • (b) make the shortcuts UI hide the internal fact that the default shortcuts do not get removed but disabled and make it seem in the UI as if these were getting removed (even though underneath we will be just marking the defaults as disabled) - we should then still hold the row with empty list of shortcuts to allow resetting the shortcut to defaults

I tend to think that (b) is a better option.

Cross-ref #15038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants