Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline completer ghost removal causes unnecessary editor refresh when no ghosts are present #15972

Open
krassowski opened this issue Mar 12, 2024 · 0 comments

Comments

@krassowski
Copy link
Member

Description

Even after disabling the cell toolbar (#15971), switching cells can take over 35ms. There is 5-6ms which should be recovered by not triggering code mirror logic when no ghost text is present:

Reproduce

image

See #15465 and #15971 and

Expected behavior

The ghost text logic does not trigger expensive CodeMirror logic when not needed. Ideally it is not added as an extension if all inline completion providers are disabled.

Context

  • Browser and version: Chrome 120+
  • JupyterLab version: 4.1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants