Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update:dependency script should bump dependencies in dev_mode #16019

Open
jtpio opened this issue Mar 19, 2024 · 1 comment
Open

update:dependency script should bump dependencies in dev_mode #16019

jtpio opened this issue Mar 19, 2024 · 1 comment

Comments

@jtpio
Copy link
Member

jtpio commented Mar 19, 2024

Description

In #15982 the @jupyter/ydoc package was bumped with the following command: jlpm update:dependency @jupyter/ydoc latest.

However it looks like it didn't bump it in dev_mode/package.json: #16018

Reproduce

Try bump a dependency that is also in dev_mode/package.json.

Expected behavior

Should bump all occurrences of that dependency.

Context

Check the update:dependency script works as expected.

@jtpio jtpio added bug status:Needs Triage Applied to new issues that need triage labels Mar 19, 2024
@jtpio jtpio changed the title update:dependency script should bump dependencies in dev_mode. update:dependency script should bump dependencies in dev_mode Mar 19, 2024
@JasonWeill JasonWeill added maintenance and removed status:Needs Triage Applied to new issues that need triage labels Mar 19, 2024
@jtpio
Copy link
Member Author

jtpio commented Mar 21, 2024

It might something to do with the integrity script instead: https://github.com/jupyterlab/jupyterlab/blob/main/buildutils/src/ensure-repo.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants