Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent listing header node checbox state #16021

Closed
erkin98 opened this issue Mar 19, 2024 · 1 comment · Fixed by #16026
Closed

Inconsistent listing header node checbox state #16021

erkin98 opened this issue Mar 19, 2024 · 1 comment · Fixed by #16026
Labels

Comments

@erkin98
Copy link
Contributor

erkin98 commented Mar 19, 2024

Description

File Browser Dir listing header checbox is not working correctly due to click event listener added listing.ts:2506. So it is prevent header checkbox persist its state
image
image

Reproduce

  1. Go to 'File Browser'
  2. Click on 'Listing Header Checkbox'
  3. See error 'All checked but header'

Expected behavior

It should check all

Context

  • Operating System and version: Linux Ubuntu 22.04
  • Browser and version: Chrome 122
  • JupyterLab version: 4.1.0
Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.
@erkin98 erkin98 added the bug label Mar 19, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Mar 19, 2024
@erkin98
Copy link
Contributor Author

erkin98 commented Mar 19, 2024

I'll create PR soon for a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants