Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting shortcuts in language other than English does not work #16039

Closed
krassowski opened this issue Mar 21, 2024 · 2 comments · Fixed by #16043
Closed

Sorting shortcuts in language other than English does not work #16039

krassowski opened this issue Mar 21, 2024 · 2 comments · Fixed by #16043
Assignees

Comments

@krassowski
Copy link
Member

Description

We should not mix up sort keys and translated labels, compase:

onClick={() => this.props.updateSort(this.props.title.toLowerCase())}

get(sortCriteria: string): string {
if (sortCriteria === 'label') {
return this.label;
} else if (sortCriteria === 'selector') {
return this.selector;
} else if (sortCriteria === 'category') {
return this.category;
} else if (sortCriteria === 'source') {
return this.source;
} else {
return '';
}
}

Reproduce

error

Expected behavior

Works

Context

  • JupyterLab version: 4.1.5
@krassowski krassowski added bug pkg:shortcuts status:Needs Triage Applied to new issues that need triage labels Mar 21, 2024
@krassowski krassowski self-assigned this Mar 21, 2024
@krassowski
Copy link
Member Author

It does not work in English either for the "Selectors" column (sort key is "selector")

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Mar 26, 2024
@JasonWeill
Copy link
Contributor

We should also be sorting using a sort algorithm suitable to the language in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants